Replace UserDiscoverer with stripped back ServerUserProvider. #3067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dualspiral
added
status: needs testing
dualspiral
force-pushed
the
api8/userdiscoverer
branch
from
54449d5 to
aa6dd44
Compare
ImMorpheus
reviewed
Jul 17, 2020
src/main/java/org/spongepowered/common/user/ServerUserProvider.java
Outdated
Show resolved
Hide resolved
dualspiral
force-pushed
the
api8/userdiscoverer
branch
from
47f3415 to
a1cf23b
Compare
The idea of the UserManager is to manage User objects, not GameProfiles. While we do some operations with GameProfiles, they mirror what Users we think have been created. The file system watching is in, but all GameProfile caching is delegated to the PlayerProfileCache, which we just get profiles from when required. * Save the username cache json when we save the worlds * Add stream methods to GameProfileCache * Create UUID only GameProfiles for files that don't have an associated profile during the stream methods
dualspiral
force-pushed
the
api8/userdiscoverer
branch
from
a1cf23b to
a6297e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea of the UserManager is to manage User objects, not GameProfiles. While we do some operations with GameProfiles, they mirror what Users we think have been created - we're not caching
GameProfiles.The file system watching is in, but all GameProfile caching is delegated to the PlayerProfileCache, which we just get profiles from when required.
It needs some testing, but it seems to at least grab the right user file and I can see it stores the UUIDs of the files that exist - which is the point really.
Note that I have not brought over the notion that banned/whitelisted profiles necessarily have a
Userattached - they don't! If you want a users associated with a banned player, get the banned user's profile and create it.Closes #3059